Update logic to handle calendar WRITE/FULL_ACCESS instead of READ/FULL_ACCESS #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
mvanbeusekom
requested changes
Oct 17, 2023
| // Deny CALENDAR_FULL_ACCESS permission if manifest is not listing both read- and write permissions. | ||
| // Otherwise, we will only ask for READ permission and think full access is granted. | ||
| // Deny CALENDAR_FULL_ACCESS permission if manifest is not listing both write- and read permissions. | ||
| // Otherwise, we will only ask for WRITE permission and think full access is granted. |
There was a problem hiding this comment.
Remove this sentence, upon first read this is a bit confusing and I think the first sentence in the comment already explains enough.
JeroenWeener
force-pushed
the
enhancement/1182-2
branch
from
dad9fc4 to
55ebee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calendar permission has been split into read-only and full access, as this split can be facilitated by Android's read/write split and iOS's read/full-access split. However, it turns out that iOS's calendar permissions are split in write/full-access instead. Therefore, the new calendar split for the app-facing package will be write-only and full access.
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.